Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

test.py: only run *.gen.sh scripts actually generated during that run#29

Closed
kkysen wants to merge 3 commits intomasterfrom
kkysen/only-run-generated-gen.sh-scripts
Closed

test.py: only run *.gen.sh scripts actually generated during that run#29
kkysen wants to merge 3 commits intomasterfrom
kkysen/only-run-generated-gen.sh-scripts

Conversation

@kkysen
Copy link
Contributor

@kkysen kkysen commented Nov 17, 2025

Otherwise, a previously generated *.gen.sh file will still be run even if it's no longer supposed to be generated (and isn't anymore).

@kkysen kkysen requested a review from fw-immunant November 17, 2025 20:59
@kkysen kkysen force-pushed the kkysen/only-run-generated-gen.sh-scripts branch from 20cabfa to d3ff86f Compare November 17, 2025 21:18
Base automatically changed from kkysen/fix-uv to master November 17, 2025 22:09
@kkysen kkysen requested a review from fw-immunant November 17, 2025 22:22
Copy link
Contributor

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@kkysen
Copy link
Contributor Author

kkysen commented Nov 17, 2025

Ugh, something got messed up in how the script is run/Python version.

@kkysen kkysen force-pushed the kkysen/only-run-generated-gen.sh-scripts branch from 48065a0 to b3a64d0 Compare November 22, 2025 00:16
@ahomescu
Copy link
Contributor

ahomescu commented Dec 3, 2025

@kkysen You should move this to the main c2rust repo.

Otherwise, a previously generated `*.gen.sh` file will still be run
even if it's no longer supposed to be generated (and isn't anymore).
We search for and find non-generated scripts (`.sh`, but not `.gen.sh`),
whereas we record all generated scripts, which we then combine to get all scripts.
@kkysen
Copy link
Contributor Author

kkysen commented Dec 3, 2025

@kkysen kkysen closed this Dec 3, 2025
@kkysen kkysen deleted the kkysen/only-run-generated-gen.sh-scripts branch December 3, 2025 02:37
kkysen added a commit to immunant/c2rust that referenced this pull request Dec 8, 2025
…un (#1488)

* Moving immunant/c2rust-testsuite#29.

Otherwise, a previously generated `*.gen.sh` file will still be run even
if it's no longer supposed to be generated (and isn't anymore).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants